Repository navigation
test(phel): add :phel branch for pr-str/prn-str character printing - #21
Merged
Merged
Conversation
Phel has no character type, so \A / \space are single-character strings
and print quoted ("A" / " "), matching the char-less-host branches
(:cljs, :lpy) rather than JVM's \A / \space.
Chemaclass
added a commit
to phel-lang/phel-lang
that referenced
this pull request
Jul 17, 2026
Suite now carries a :phel reader-conditional branch for pr-str/prn-str character printing (phel-lang/clojure-test-suite#21). Related to #2743
Chemaclass
added a commit
to phel-lang/phel-lang
that referenced
this pull request
Jul 17, 2026
* feat(core): add pr, prn, pr-str, prn-str readable-print family Phel has no distinct char type, so character literals such as \A are single-character strings and print readably as "A" (ClojureScript-aligned, not Clojure/JVM's \A). Extracts a shared print-joined helper so print-str and pr-str share the space-join loop. Related to #2743 * test: bump clojure-test-suite pin for :phel pr-str/prn-str branch Suite now carries a :phel reader-conditional branch for pr-str/prn-str character printing (phel-lang/clojure-test-suite#21). Related to #2743
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phel now has
pr-str/prn-str(phel-lang/phel-lang#2761). Phel has no character type, so\A/\spaceare single-character strings and print quoted ("A"/" ") — the same host model as the existing:cljsand:lpy(Basilisp) branches, not JVM's\A/\space.Adds a
:phelbranch topr_str.cljcandprn_str.cljcmatching the:lpystring (quoted char,17.0float). Without it, Phel falls through to:default(JVM) and fails on the character elements.Verified: Phel selects the
:phelreader-conditional branch, and(pr-str nil "a" "string" \A \space 1 17.0 [:a :b] {:c :d} #{:e})produces exactly the:phel/:lpystring.